Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic-core): generate state reactions to events #2221

Merged
merged 1 commit into from
May 23, 2024

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented May 23, 2024

Description of changes:

This change adds a test helper method for state machine implementations that prints out each state and its reaction to an event, i.e. if it is successful or if it's an invalid transition. This was being done manually for the current state implementations so each of those were cleaned up as part of this.

Testing:

The existing snapshot tests have been updated to use the new helper method.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft force-pushed the camshaft/state-transition-snapshots branch 2 times, most recently from eb19e16 to 72e39b0 Compare May 23, 2024 17:02
@camshaft camshaft force-pushed the camshaft/state-transition-snapshots branch from 72e39b0 to 234df13 Compare May 23, 2024 17:05
@camshaft camshaft marked this pull request as ready for review May 23, 2024 17:07
@camshaft camshaft merged commit c96e57c into main May 23, 2024
127 of 128 checks passed
@camshaft camshaft deleted the camshaft/state-transition-snapshots branch May 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants